Escape @nospecialize macro output#61362
Merged
oscardssmith merged 2 commits intoJuliaLang:masterfrom Mar 19, 2026
Merged
Conversation
Keno
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nospecializeand@specializerefer to names passed as macro arguments, soshould theoretically escape them in their expansion. They currently work
without escaping because macroexpand.scm makes a special case for
:metaforms.Unfortunately, that special handling escapes
:metatoo aggressively:This PR doesn't fix the above or change any current behaviour, but at least
ensures that JuliaLowering doesn't need to introduce the same bug. There are
alternatives if this doesn't work, but all would be hacky.