Remove unnecessary masking when converting from Bool#60435
Merged
adienes merged 1 commit intoJuliaLang:masterfrom Dec 20, 2025
Merged
Remove unnecessary masking when converting from Bool#60435adienes merged 1 commit intoJuliaLang:masterfrom
adienes merged 1 commit intoJuliaLang:masterfrom
Conversation
The masking `& 1` was added to remove unused upper bits in `Bool`s. However, since then, Julia have decided that constructing booleans with bitpatterns other than 0b0 and 0b1 is undefined behaviour, and codegen now inserts these masks when loading booleans from memory. Therefore, they are redundant.
Member
|
Does this run into issues of the same variety as #52189? |
vtjnash
approved these changes
Dec 19, 2025
Member
Author
|
@oscardssmith I don't know to be honest, but I would think they are different issues - by the time the code affected by this PR is running, it's already a Julian |
Member
Author
|
Welp, turns out it doesn't matter, because the |
Member
|
Right. so this PR is good, but only because Jameson is saving you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The masking
& 1was added to remove unused upper bits inBools. However, since then, Julia have decided that constructing booleans with bitpatterns other than 0b0 and 0b1 is undefined behaviour, and codegen now inserts these masks when loading booleans from memory. Therefore, they are redundant.See #60425