Finish PR: inference: fix the ptrfree field check#60214
Merged
aviatesk merged 3 commits intoJuliaLang:masterfrom Nov 24, 2025
Merged
Finish PR: inference: fix the ptrfree field check#60214aviatesk merged 3 commits intoJuliaLang:masterfrom
aviatesk merged 3 commits intoJuliaLang:masterfrom
Conversation
The previous implementation using `is_undefref_field` was flawed. We can now implement a more robust check with `DataTypeFieldDesc`.
Co-authored-by: James Wrigley <JamesWrigley@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address the
# TODOitem in #57550.Unconditionally indexing
DataTypeFieldDesc(dt::DataType)[fidx]will error whendthas no layout because we defineFor all the
DataTypes I could find, they only haddt.layout == C_NULLif!isconcretetype(dt), so maybe it would be preferable to check if they're!isconcretetyperather than checking ifdt.layout == C_NULL, but I figured it'd be safer to just mimic the validation logic inDataTypeFieldDescinstead.