Skip to content

use the versioned MPFR in ccalls#59550

Merged
giordano merged 1 commit intoJuliaLang:masterfrom
nsajko:versioned-mpfr-ccall
Sep 14, 2025
Merged

use the versioned MPFR in ccalls#59550
giordano merged 1 commit intoJuliaLang:masterfrom
nsajko:versioned-mpfr-ccall

Conversation

@nsajko
Copy link
Copy Markdown
Member

@nsajko nsajko commented Sep 13, 2025

The other ccalls to MPFR use the versioned lib name. I suppose the ccalls modified in this change were simply missed in PR #47676.

@nsajko nsajko added external dependencies Involves LLVM, OpenBLAS, or other linked libraries bignums BigInt and BigFloat JLLs labels Sep 13, 2025
@nsajko nsajko marked this pull request as ready for review September 13, 2025 18:28
@nsajko
Copy link
Copy Markdown
Member Author

nsajko commented Sep 13, 2025

cc @gbaraldi as author of PR #47676

@nsajko nsajko force-pushed the versioned-mpfr-ccall branch from c3a3420 to 01c56d2 Compare September 14, 2025 02:58
The other `ccall`s to MPFR use the versioned lib name. I suppose the
`ccall`s modified in this change were simply missed in PR JuliaLang#47676.
@nsajko nsajko force-pushed the versioned-mpfr-ccall branch from 01c56d2 to 830b964 Compare September 14, 2025 12:48
@ViralBShah ViralBShah added merge me PR is reviewed. Merge when all tests are passing and removed merge me PR is reviewed. Merge when all tests are passing labels Sep 14, 2025
@ViralBShah
Copy link
Copy Markdown
Member

@nsajko Please merge when ready.

@giordano giordano merged commit 2e26583 into JuliaLang:master Sep 14, 2025
9 checks passed
@nsajko nsajko deleted the versioned-mpfr-ccall branch September 14, 2025 18:43
@nsajko
Copy link
Copy Markdown
Member Author

nsajko commented Sep 14, 2025

The force pushes were just to restart CI, there were no changes after the approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bignums BigInt and BigFloat external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants