Skip to content

Restore stacktrace scrubing in fallback REPL.#59241

Merged
Keno merged 7 commits intoJuliaLang:masterfrom
BioTurboNick:scrub_client_bt_restore
Aug 14, 2025
Merged

Restore stacktrace scrubing in fallback REPL.#59241
Keno merged 7 commits intoJuliaLang:masterfrom
BioTurboNick:scrub_client_bt_restore

Conversation

@BioTurboNick
Copy link
Copy Markdown
Contributor

Fixes #59223 by adding intermediary function names to use the same __repl_entry prefix.

@BioTurboNick BioTurboNick marked this pull request as ready for review August 9, 2025 18:35
@Keno
Copy link
Copy Markdown
Member

Keno commented Aug 11, 2025

LGTM, but needs a test

@BioTurboNick
Copy link
Copy Markdown
Contributor Author

BioTurboNick commented Aug 11, 2025

Added tests. Let me know though if my assumption about Meta.lower not throwing exceptions (in a way that can be mocked here) is accurate. I looked to see if there was a way and there didn't seem to be.

Comment thread test/client.jl Outdated
@BioTurboNick
Copy link
Copy Markdown
Contributor Author

A slight wrinkle here is that the eval frame will still show up in stacktraces. REPL.jl gets around that by calling a C function to do the eval, which are hidden normally. But that may not be worth trying to achieve?

@Keno
Copy link
Copy Markdown
Member

Keno commented Aug 11, 2025

Is it really that important? The fallback REPL isn't really supposed to be used regularly.

@Keno Keno merged commit 9c94e7a into JuliaLang:master Aug 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scrub_repl_backtrace no longer successfully scrubs internal frames from client.jl fallback REPL

3 participants