codegen: More robustness for invalid :invoke IR#58631
Merged
Conversation
See #58429 for general discussion of these kinds of errors. We don't verify this one in the IR verifier, because it's currently not really part of the structural invariants of the IR. One could imagine using IRCode with a non-codegen backend that uses something else here. Nevertheless, codegen needs to complain of course if someone put something here it doesn't understand.
topolarity
reviewed
Jun 4, 2025
| assert(jl_is_code_instance(ci)); | ||
| mi = jl_get_ci_mi((jl_code_instance_t*)ci); | ||
| } else { | ||
| emit_error(ctx, "(Internal ERROR - IR Validity): Invoke target is not a method instance or code instance"); |
Member
There was a problem hiding this comment.
This should probably panic, instead of being an error
Member
Author
There was a problem hiding this comment.
No, panics are annoying because they delete all your state, so you can't introspect what went wrong. Obviously continuing to run after this is undefined behavior, but at least you can maybe look at a thing or two at the REPL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #58429 for general discussion of these kinds of errors. We don't verify this one in the IR verifier, because it's currently not really part of the structural invariants of the IR. One could imagine using IRCode with a non-codegen backend that uses something else here. Nevertheless, codegen needs to complain of course if someone put something here it doesn't understand.