Conversation
74881a7 to
7499731
Compare
7499731 to
6a9ac5f
Compare
|
Scheduled pipeline running at https://buildkite.com/julialang/julia-master-scheduled/builds/1161. |
| +unw_word_t _UPT_ptrauth_insn_mask (UNUSED unw_addr_space_t as, UNUSED void *arg) | ||
| { | ||
| return 0; | ||
| } No newline at end of file |
There was a problem hiding this comment.
For what is worth, applying the patch is successful but there's a warning because of missing newline at the end of this line
% patch -p1 -f -u -l < libunwind-missing-parameter-names.patch
patching file src/ptrace/_UPT_ptrauth_insn_mask.c
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 49 with fuzz 1.Is there a way to instruct Claude & friends to use the GitHub-generated patch, which also retains attribution?
There was a problem hiding this comment.
I told it that in #58629 but only after I did the PR update. Let's see if it does better with the new instructions.
There was a problem hiding this comment.
See if you like this better.
Apply patch from libunwind/libunwind#853 to add missing parameter names in _UPT_ptrauth_insn_mask function to comply with ISO/IEC 9899. Prior to GCC 11, omitting parameter names in function definitions was an error. GCC 11 changed this behavior in commit https://gcc.gnu.org/pipermail/gcc-cvs/2020-October/336068.html to allow omitted parameter names as a C2x extension, making it a pedantic warning instead of an error. Since we build without -Wpedantic, the code compiles fine with GCC 11+ but fails with older GCC versions. Fixes scheduled CI failures in libunwind build: https://buildkite.com/julialang/julia-master-scheduled/builds/1160
c85874d to
e3a32d4
Compare
|
Sigh, looks like the patch got corrupted again. Not sure exactly how that happened, but may have happened after I accidentally pushed over this branch. Sorry! Will fix. |
Apply patch from libunwind/libunwind#853 to add missing parameter names
in _UPT_ptrauth_insn_mask function to comply with ISO/IEC 9899.
Prior to GCC 11, omitting parameter names in function definitions
was an error. GCC 11 changed this behavior in commit
https://gcc.gnu.org/pipermail/gcc-cvs/2020-October/336068.html
to allow omitted parameter names as a C2x extension, making it
a pedantic warning instead of an error.
Since we build without -Wpedantic, the code compiles fine with
GCC 11+ but fails with older GCC versions.
Fixes scheduled CI failures in libunwind build:
https://buildkite.com/julialang/julia-master-scheduled/builds/1160