CI: PrAssignee.yml: Add note about public membership in the bot comment#58626
Merged
IanButterworth merged 1 commit intomasterfrom Jun 4, 2025
Merged
CI: PrAssignee.yml: Add note about public membership in the bot comment#58626IanButterworth merged 1 commit intomasterfrom
PrAssignee.yml: Add note about public membership in the bot comment#58626IanButterworth merged 1 commit intomasterfrom
Conversation
Member
Author
|
I've done some research, and I don't think we can detect the case where someone is a JuliaLang committer but has their org membership set to private. For now, I think this PR (a brief note in the bot comment) is the best option we have. I'll continue to research this topic. FWIW, we already require (in other infrastructure areas) that JuliaLang committers publicize their org membership. For example, a JuliaLang committer cannot invoke Nanosoldier if their org membership is private. So I don't think it's too bad if we have to ask all JuliaLang committers to please publicize their org membership. |
LilithHafner
approved these changes
Jun 3, 2025
Member
LilithHafner
left a comment
There was a problem hiding this comment.
This aligns with my research as well.
b026c23 to
c7d258d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the bottom of the bot comment, add a brief comment asking Julia committers to make sure that their org membership is public.