REPL: delay compilation in macros like @time to avoid the need for @eval#58015
REPL: delay compilation in macros like @time to avoid the need for @eval#58015IanButterworth wants to merge 2 commits intoJuliaLang:masterfrom
@time to avoid the need for @eval#58015Conversation
|
I'm not sure I like this. But if we want to do it, wouldn't it make more sense to put the |
|
The concern was about someone putting a |
2b73c75 to
f69aa4f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
This is working now with the new I can fix docstrings and add tests if we're ok with this approach. Perhaps discuss it in triage today? |
|
Triage were positive about this but did suggest @Keno review usage of this new annotation. |
5f9a93a to
2679a1d
Compare
vtjnash
left a comment
There was a problem hiding this comment.
I feel fairly certain this is a major breaking change (it overrides the force compile that is part of the current spec) and should not be merged, though I feel somewhat disinterested in trying to give a real review and explanation, which I know is unfair
|
Ok. I'm not much up for a vague challenge to get this in, so I'll close. Thanks for being upfront. |
|
Yes, it would be nice to be able to say both: don't compile before execution reaches "here," but you must compile before execution reaches "there." |
Avoids the need to use
@evalwith@timeetc. in the REPLWith this
Without (master)
However it currently breaks for silenced entries.. the expr check needs work..