Closed
Conversation
This was referenced Feb 21, 2025
This was referenced Mar 24, 2025
51 tasks
53 tasks
58 tasks
Member
|
It is mentioned in the @vtjnash reacted with a 👎 perhaps you could elaborate what your concerns are? |
Member
|
There are almost no uses of this outside of internal scheduler code that are not subtle races and UB if you access this value |
Member
|
OK, I find it a convincing argument that this should not be merged. But then any docstrings of exported/public bindings referencing The only docstring I found referencing |
This was referenced Sep 15, 2025
This was referenced Sep 24, 2025
Merged
Member
|
Merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxthreadidis in the documentation and is referred to by other public docstrings so it should at least itself be public. Looking at what else is being exported I think this has the same "weight".