[Random] Fix typo in _bits2float for Float32#57337
Closed
giordano wants to merge 1 commit intoJuliaLang:masterfrom
Closed
[Random] Fix typo in _bits2float for Float32#57337giordano wants to merge 1 commit intoJuliaLang:masterfrom
_bits2float for Float32#57337giordano wants to merge 1 commit intoJuliaLang:masterfrom
Conversation
Member
|
#57338 has a test as well which is perhaps a bit too specific but at least it tests that the change fixes the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #57336. I don't know what a good test for this would be (besides testing exact values or
allunique(rand(T, 4))?), suggestions welcome.