broadcast: align ndims implementation with intent behind code (#56999)#57322
Closed
nsajko wants to merge 1 commit intoJuliaLang:backports-release-1.10from
Closed
broadcast: align ndims implementation with intent behind code (#56999)#57322nsajko wants to merge 1 commit intoJuliaLang:backports-release-1.10from
ndims implementation with intent behind code (#56999)#57322nsajko wants to merge 1 commit intoJuliaLang:backports-release-1.10from
Conversation
…aLang#56999) The `N<:Integer` constraint was nonsensical, given that `(N === Any) || (N isa Int)`. N5N3 noticed this back in 2022: JuliaLang#44061 (comment) Follow up on JuliaLang#44061. Also xref JuliaLang#45477. (cherry picked from commit d3964b6)
topolarity
reviewed
Feb 10, 2025
| Base.ndims(BC::Type{<:Broadcasted{<:Any,Nothing}}) = _maxndims_broadcasted(BC) | ||
| # the `AbstractArrayStyle` type parameter is required to be either equal to `Any` or be an `Int` value | ||
| Base.ndims(BC::Type{<:Broadcasted{<:AbstractArrayStyle{Any},Nothing}}) = _maxndims_broadcasted(BC) | ||
| Base.ndims(::Type{<:Broadcasted{<:AbstractArrayStyle{N},Nothing}}) where {N} = N::Int |
Member
There was a problem hiding this comment.
It's probably worth adding a test of this method directly, in addition to the end-to-end broadcasting test
Member
Author
There was a problem hiding this comment.
I guess that's a good idea, but this is just a backport PR, new tests should probably go to the master branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #56999 to v1.10.
The
N<:Integerconstraint was nonsensical, given that(N === Any) || (N isa Int). N5N3 noticed this back in 2022:#44061 (comment)
Follow up on #44061. Also xref #45477.
(cherry picked from commit d3964b6)