Skip to content

Delete unnecessary methods in OffsetArrays.jl#56564

Merged
KristofferC merged 1 commit intoJuliaLang:masterfrom
JamesWrigley:offsetarrays-methods
Nov 15, 2024
Merged

Delete unnecessary methods in OffsetArrays.jl#56564
KristofferC merged 1 commit intoJuliaLang:masterfrom
JamesWrigley:offsetarrays-methods

Conversation

@JamesWrigley
Copy link
Copy Markdown
Member

These are all defined elsewhere in Base:

WARNING: Method definition fill(Any, Tuple{Vararg{Union{Integer, Base.AbstractUnitRange{T} where T}, N}}) where {N} in module Base at array.jl:542 overwritten in module OffsetArrays at /opt/hostedtoolcache/julia/nightly/x64/share/julia/test/testhelpers/OffsetArrays.jl:574.
WARNING: Method definition zeros(Type{T}, Tuple{Vararg{Union{Integer, Base.AbstractUnitRange{T} where T}, N}}) where {T, N} in module Base at array.jl:603 overwritten in module OffsetArrays at /opt/hostedtoolcache/julia/nightly/x64/share/julia/test/testhelpers/OffsetArrays.jl:576.
WARNING: Method definition ones(Type{T}, Tuple{Vararg{Union{Integer, Base.AbstractUnitRange{T} where T}, N}}) where {T, N} in module Base at array.jl:603 overwritten in module OffsetArrays at /opt/hostedtoolcache/julia/nightly/x64/share/julia/test/testhelpers/OffsetArrays.jl:578.
WARNING: Method definition trues(Tuple{Vararg{Union{Integer, Base.AbstractUnitRange{T} where T}, N}}) where {N} in module Base at bitarray.jl:426 overwritten in module OffsetArrays at /opt/hostedtoolcache/julia/nightly/x64/share/julia/test/testhelpers/OffsetArrays.jl:580.
WARNING: Method definition falses(Tuple{Vararg{Union{Integer, Base.AbstractUnitRange{T} where T}, N}}) where {N} in module Base at bitarray.jl:407 overwritten in module OffsetArrays at /opt/hostedtoolcache/julia/nightly/x64/share/julia/test/testhelpers/OffsetArrays.jl:582.

(similar to #56414)

These are all defined elsewhere in Base.
@jishnub jishnub added the merge me PR is reviewed. Merge when all tests are passing label Nov 15, 2024
@JamesWrigley
Copy link
Copy Markdown
Member Author

There's some funky build failures and one test failure, but AFAICT they're unrelated.

@KristofferC KristofferC merged commit 55bdb54 into JuliaLang:master Nov 15, 2024
@JamesWrigley JamesWrigley deleted the offsetarrays-methods branch November 15, 2024 11:26
@jishnub jishnub removed the merge me PR is reviewed. Merge when all tests are passing label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants