trimming: don't abort where we used to resolve dynamic calls#56271
Merged
topolarity merged 1 commit intoJuliaLang:masterfrom Oct 21, 2024
Merged
trimming: don't abort where we used to resolve dynamic calls#56271topolarity merged 1 commit intoJuliaLang:masterfrom
topolarity merged 1 commit intoJuliaLang:masterfrom
Conversation
This call resolution code was deleted in JuliaLang#56179 (rightfully so - this code really should never have been here in the first place) but it should be a no-op not an abort, until we implement this in inference.
Member
Author
|
This still means a regression for |
vtjnash
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This call resolution code was deleted in #56179 (rightfully so), but it should be a no-op until we implement this in inference.