WIP: save registers of tasks that were active right before GC on a ucontext_t for conservative scanning#55003
Closed
WIP: save registers of tasks that were active right before GC on a ucontext_t for conservative scanning#55003
Conversation
Member
Author
|
One clarification: this call allows us to get the contexts of the tasks that were scheduled right before GC started (i.e. the tasks that read from the safe-point page and incurred a segmentation fault). Getting register/stack-pointer information for tasks that were de-scheduled when GC started is easier because they were saved in a |
…ontext_t for conservative scanning
5c958a5 to
b47b0ea
Compare
fingolfin
reviewed
Jul 3, 2024
| // Requires `GC_SAVE_CONTEXT_FOR_CONSERVATIVE_SCANNING` to be defined. | ||
| // If ctx is NULL, the registers of the thread at the moment of the call are saved, else | ||
| // the registers of the context ctx are saved into the `ctx_at_the_time_gc_started` field of Julia's TLS. | ||
| JL_DLLEXPORT void jl_save_context_for_conservative_scanning(jl_ptls_t ptls, void *ctx); |
Member
There was a problem hiding this comment.
It's not clear to me who would be calling this and when. And depending on the answer to that possibly also whether it is idempotent (i.e. if I accidentally call it twice, is that safe).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Garbage collectors that are fully or partially conservative usually need to look at what was stored in the registers of the tasks right before GC started, and may also benefit from having information about the stack pointer at the time GC started in order to determine the lower/upper bounds of the stack.
Let's expose a call to support register saving for conservative GCs.
The current implementation is WIP because:
jl_ucontext_titself, instead of adding a new field to the TLS as I'm doing now.x86_64Linux for now.CC: @qinsoon, @kpamnany.