Revert "REPL: spawn prompt! to avoid blocking typing, fix pkg repl transition sequencing"#54862
Closed
IanButterworth wants to merge 1 commit intomasterfrom
Closed
Revert "REPL: spawn prompt! to avoid blocking typing, fix pkg repl transition sequencing"#54862IanButterworth wants to merge 1 commit intomasterfrom
IanButterworth wants to merge 1 commit intomasterfrom
Conversation
… sequenc…" This reverts commit 6f39acb.
This was referenced Jun 20, 2024
Member
Author
|
Actual fix in #54865 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #54785
The state before this PR might have had design issues that need fixing, but didn't error, so revert and continue design work off of master.