Follow up #54772 - don't accidentally put Module into method name slot#54856
Merged
Follow up #54772 - don't accidentally put Module into method name slot#54856
Module into method name slot#54856Conversation
vtjnash
reviewed
Jun 20, 2024
|
|
||
| # Test that lowering doesn't accidentally put a `Module` in the Method name slot | ||
| let src = @Meta.lower let capture=1 | ||
| global foo_lower_block |
Member
There was a problem hiding this comment.
IIUC, the reason this must be in lowering (and wrong to inspect the signature unless lowering instructs that it must) is that this line could be:
Suggested change
| global foo_lower_block | |
| global const foo_lower_block = Base.redirect_stdin |
And looking at the signature would wrongly name this Method as Base.RedirectStdStream(0), when syntactically it has the different intended name foo_lower_block
vtjnash
reviewed
Jun 20, 2024
The `:outerref` removal (#54772) ended up accidentally putting a `Module` argument into 3-argument `:method` due to a bad refactor. We didn't catch this in the tests, because the name slot of 3-argument `:method` is unused (except for external method tables), but ordinarily contains the same data as 1-argument `:method`. That said, some packages in the Revise universe look at this (arguably incorrectly, since they should be looking at the signature instead), so it should be correct until we fix Revise, at which point we may just want to always pass `false` here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:outerrefremoval (#54772) ended up accidentally putting aModuleargument into 3-argument:methoddue to a bad refactor. We didn't catch this in the tests, because the name slot of 3-argument:methodisunused (except for external method tables), but ordinarily contains
the same data as 1-argument
:method.That said, some packages in the Revise universe look at this (arguably incorrectly, since they should be looking at the signature instead), so it should be correct until we fix Revise, at which point we may just want to always pass
falsehere.