backport 1.10: create phantom task for GC threads (#53815)#54632
Merged
KristofferC merged 2 commits intorelease-1.10from May 31, 2024
Merged
backport 1.10: create phantom task for GC threads (#53815)#54632KristofferC merged 2 commits intorelease-1.10from
KristofferC merged 2 commits intorelease-1.10from
Conversation
A common idiom used throughout the codebase is to get a pointer to thread-local-state through `jl_current_task->ptls`. Create a phantom task for GC threads so that we can make use of this idiom when running in the GC threads as well. Idea originally suggested by @vchuravy, bugs are mine. (cherry picked from commit 9636ef7)
Member
|
(I would have happily provided such a PR, too, just to save you work. Apologies if I should just have done that, I am not sure what the right "protocol" is -- you are already doing a ton of work and I don't mean to be a burden) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A common idiom used throughout the codebase is to get a pointer to thread-local-state through
jl_current_task->ptls.Create a phantom task for GC threads so that we can make use of this idiom when running in the GC threads as well.
Idea originally suggested by @vchuravy, bugs are mine.
(cherry picked from commit 9636ef7)