Merged
Conversation
topolarity
reviewed
May 21, 2024
Member
Author
|
With the latest change we avoid any of the wird invariant.load stuff but it still lifts the check to a preheader in a function like function foo(oc, arr)
sum = 0.0
for i in eachindex(arr)
if (oc.world) == Base.tls_world_age()
sum += oc(arr[i])
else
sum += arr[i]
end
end
sum
end |
topolarity
reviewed
May 22, 2024
topolarity
reviewed
May 22, 2024
topolarity
requested changes
Jun 6, 2024
topolarity
reviewed
Jun 6, 2024
topolarity
requested changes
Jun 7, 2024
topolarity
approved these changes
Jun 7, 2024
Member
topolarity
left a comment
There was a problem hiding this comment.
Nice! Thanks for iterating on this until all the details were right 👍
255ef33 to
70e96fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so we avoid a ccall boundary and potentially optimize away repeated world age checks