Add inventory writing to 1.10 via DocumenterInventoryWritingBackport#53597
Closed
goerz wants to merge 1 commit intoJuliaLang:backports-release-1.10from
Closed
Add inventory writing to 1.10 via DocumenterInventoryWritingBackport#53597goerz wants to merge 1 commit intoJuliaLang:backports-release-1.10from
goerz wants to merge 1 commit intoJuliaLang:backports-release-1.10from
Conversation
Contributor
|
This looks fine to me. @KristofferC, do you think it would be okay to get this onto the 1.10 release branch? |
Member
|
Yes, but better to make it against #53714 so that it goes through the CI together with the rest of the stuff. |
Contributor
Author
|
I'm on it... |
5c022e7 to
2d1442f
Compare
Contributor
Author
|
@KristofferC Ok, I've rebased the PR and changed the base branch to |
Contributor
Author
|
So did this end up being backported manually (cherry-picked?) for the next 10.x release? Sorry I’m confused about the back porting process. |
Member
|
I forgot about this one but I re-opened it #54199. Will still be in 1.10.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from #53571 (comment) with the context in https://discourse.julialang.org/t/ann-documenter-v1-3-0-inventories/111139
I'm not completely sure what the process is for backporting to the 1.10 track. I've based this PR on the
release-1.10branch, which seemed like the most likely correct thing to do, but if it's not, let me know.This does not address the backport of the inventory writing to the 1.11 track, which should be "easier" (cherry-picking #53571 onto the
release-1.11branch?)