Skip to content

Move isassigned within inbounds in copyto_unaliased#53311

Merged
jishnub merged 2 commits intomasterfrom
jishnub/copytoinboundscartinds
Feb 14, 2024
Merged

Move isassigned within inbounds in copyto_unaliased#53311
jishnub merged 2 commits intomasterfrom
jishnub/copytoinboundscartinds

Conversation

@jishnub
Copy link
Copy Markdown
Member

@jishnub jishnub commented Feb 13, 2024

This matches the other branches where the isassigned and _unsetindex! are within @inbounds blocks, and this might help with performance after #53305

@jishnub jishnub added performance Must go faster arrays [a, r, r, a, y, s] labels Feb 13, 2024
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Feb 13, 2024
@jishnub jishnub merged commit 52006ae into master Feb 14, 2024
@jishnub jishnub deleted the jishnub/copytoinboundscartinds branch February 14, 2024 12:13
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrays [a, r, r, a, y, s] performance Must go faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants