Skip to content

add ability to specify heap size hint as a percent#52979

Merged
JeffBezanson merged 1 commit intomasterfrom
jb/heappercent
Feb 14, 2024
Merged

add ability to specify heap size hint as a percent#52979
JeffBezanson merged 1 commit intomasterfrom
jb/heappercent

Conversation

@JeffBezanson
Copy link
Copy Markdown
Member

@JeffBezanson JeffBezanson commented Jan 19, 2024

also fix overflowed subtraction with size hints < 250mb --- we should pick some minimum soft heap limit; I chose 1mb here but it could be anything.

@JeffBezanson JeffBezanson added the GC Garbage collector label Jan 19, 2024
vtjnash
vtjnash reviewed Jan 19, 2024
View reviewed changes
vtjnash
vtjnash reviewed Jan 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtjnash vtjnash mentioned this pull request Feb 8, 2024
Merged
@KristofferC
Copy link
Copy Markdown
Member

KristofferC commented Feb 13, 2024

Bump, can be merged?

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Feb 13, 2024

No, it failed on CI:


2024-02-01 04:27:38 UTC	Error in testset cmdlineargs:
2024-02-01 04:27:38 UTC	Test Failed at C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-ec4182e384\share\julia\test\cmdlineargs.jl:1059
2024-02-01 04:27:38 UTC	  Expression: abs(maxmem - (hint - 250 * 1024 * 1024)) / maxmem < 0.01
2024-02-01 04:27:38 UTC	   Evaluated: 4.170485178629558 < 0.01

@vtjnash vtjnash added this to the 1.11 milestone Feb 13, 2024
@JeffBezanson
add ability to specify heap size hint as a percent
5a77f9c 
also fix overflowed subtraction with size hints < 250mb
@JeffBezanson
Copy link
Copy Markdown
Member Author

JeffBezanson commented Feb 13, 2024

Seems I did not account for 32-bit machines with 32gb of memory 🤔 😕

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Feb 13, 2024

Nobody ever does, until they realize it is probably the most common 32 bit machines now, haha

@JeffBezanson JeffBezanson merged commit 3e6ff3d into master Feb 14, 2024
@JeffBezanson JeffBezanson deleted the jb/heappercent branch February 14, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash left review comments

@gbaraldi gbaraldi gbaraldi approved these changes

Assignees

No one assigned

Labels

GC Garbage collector

Projects

None yet

Milestone

1.11

Development

Successfully merging this pull request may close these issues.

4 participants

@JeffBezanson @KristofferC @vtjnash @gbaraldi