Skip to content

Allow for potential customization of TLII#51536

Closed
vchuravy wants to merge 3 commits intomasterfrom
vc/TTLI
Closed

Allow for potential customization of TLII#51536
vchuravy wants to merge 3 commits intomasterfrom
vc/TTLI

Conversation

@vchuravy
Copy link
Copy Markdown
Member

@vchuravy vchuravy commented Oct 1, 2023

Currently NFC.
The most interesting option is to disallow all libcalls,
or enable vectorization.

We could investigate:

  /// Return true if the function F has a vector equivalent with any
  /// vectorization factor.
  bool isFunctionVectorizable(StringRef F) const;
 
  /// Return the name of the equivalent of F, vectorized with factor VF. If no
  /// such mapping exists, return the empty string.
  StringRef getVectorizedFunction(StringRef F, const ElementCount &VF,
                                  bool Masked) const;

@vchuravy vchuravy requested a review from pchintalapudi October 1, 2023 22:09
@gbaraldi
Copy link
Copy Markdown
Member

gbaraldi commented Oct 2, 2023

Would this allow us to give back something like a vectorized sin?

vtjnash
vtjnash reviewed Oct 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a little risky, since LLVM declares that compilation can be done repeatably (in llc or opt for example) with this derived only from the triple:

This class [TargetLibraryInfoImpl] constructs tables that hold the target library information and make it available. However, it is somewhat expensive to compute and only depends on the triple. So users typically interact with the TargetLibraryInfo wrapper below.

Could we propose some sort of Metadata feature for LLVM that would replace the current magic global behavior of the TLII with explicit data found in the Module IR?

@vchuravy
Copy link
Copy Markdown
Member Author

vchuravy commented Oct 7, 2023 •
edited
Loading

Would this allow us to give back something like a vectorized sin?

Yes in theory, but we probably need a better mechanism than string matching.

This seems a little risky

This is what Clang does xD

@gbaraldi
Copy link
Copy Markdown
Member

gbaraldi commented Oct 18, 2023

Vectorized safepoints?

@vchuravy
Copy link
Copy Markdown
Member Author

vchuravy commented Oct 18, 2023

On issue with interoducing GC.safepoint() in a loop is that it blocks loop vectorization. This still doesn't fix it, but I need to look into wat the vectorize yes for decision making here

@vchuravy vchuravy mentioned this pull request Oct 16, 2024
Draft
@vchuravy vchuravy closed this May 14, 2025
@giordano giordano deleted the vc/TTLI branch December 19, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash left review comments

@pchintalapudi pchintalapudi Awaiting requested review from pchintalapudi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vchuravy @gbaraldi @vtjnash