Skip to content

Expose JL_TIMING tracking to VTune#49448

Merged
vchuravy merged 1 commit intomasterfrom
pc/ittapi-events
Apr 22, 2023
Merged

Expose JL_TIMING tracking to VTune#49448
vchuravy merged 1 commit intomasterfrom
pc/ittapi-events

Conversation

@pchintalapudi
Copy link
Copy Markdown
Member

@pchintalapudi pchintalapudi commented Apr 20, 2023

Examples:
image
image

@pchintalapudi pchintalapudi mentioned this pull request Apr 20, 2023
Merged
vchuravy
vchuravy reviewed Apr 20, 2023
View reviewed changes
vchuravy
vchuravy reviewed Apr 20, 2023
View reviewed changes
src/gc.c
uint64_t start_mark_time = jl_hrtime();
JL_PROBE_GC_MARK_BEGIN();
{
JL_TIMING(GC, Mark);
Copy link
Copy Markdown
Member

@vchuravy vchuravy Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topolarity Is there a way to attach a message? Would be helpful to differentiate between minor and major GC

Copy link
Copy Markdown
Member

@topolarity topolarity Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Tracy, we distinguish full sweeps based on the color associated with the event. That's one of the cases we haven't pulled up to a generic API yet:

julia/src/gc.c

Lines 3122 to 3127 in 552dd4c

#ifdef USE_TRACY
if (sweep_full) {
TracyCZoneCtx ctx = *(JL_TIMING_CURRENT_BLOCK->tracy_ctx);
TracyCZoneColor(ctx, 0xFFA500);
}
#endif

jl_timing_printf and jl_timing_show_* also allow associating strings with events, so we could use that if ITTAPI supports string metadata. Or did you have something more specialized in mind?

Copy link
Copy Markdown
Member Author

@pchintalapudi pchintalapudi Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like if we had a conditional event that would be sufficient here.

Base automatically changed from pc/ittapi-uds to master April 21, 2023 14:54
vchuravy
vchuravy reviewed Apr 22, 2023
View reviewed changes
@vchuravy vchuravy merged commit a34261f into master Apr 22, 2023
@vchuravy vchuravy deleted the pc/ittapi-events branch April 22, 2023 20:44
@topolarity
Copy link
Copy Markdown
Member

topolarity commented Apr 24, 2023

Late to the review, but once again nice work - Nice to have this on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vchuravy vchuravy vchuravy approved these changes

@topolarity topolarity Awaiting requested review from topolarity

Assignees

No one assigned

Labels

profiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pchintalapudi @topolarity @vchuravy