Skip to content

Relax type restriction in ismutationfree#48357

Merged
aviatesk merged 1 commit intomasterfrom
kf/48353
Jan 24, 2023
Merged

Relax type restriction in ismutationfree#48357
aviatesk merged 1 commit intomasterfrom
kf/48353

Conversation

@Keno
Copy link
Copy Markdown
Member

@Keno Keno commented Jan 20, 2023

Fixes #48353.

@aviatesk
Copy link
Copy Markdown
Member

aviatesk commented Jan 20, 2023

We probably want to remove the type restriction of isidentityfree too?

@maleadt maleadt added the bugfix This change fixes an existing bug label Jan 24, 2023
@maleadt
Copy link
Copy Markdown
Member

maleadt commented Jan 24, 2023

Rebased and added isidentityfree.

@maleadt maleadt requested a review from aviatesk January 24, 2023 09:05
aviatesk
aviatesk approved these changes Jan 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maleadt.

@maleadt maleadt added the merge me PR is reviewed. Merge when all tests are passing label Jan 24, 2023
@aviatesk aviatesk merged commit b8adb2e into master Jan 24, 2023
@aviatesk aviatesk deleted the kf/48353 branch January 24, 2023 10:57
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aviatesk aviatesk aviatesk approved these changes

Assignees

No one assigned

Labels

bugfix This change fixes an existing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PkgEval: RoME.jl triggers MethodError in compiler

4 participants

@Keno @aviatesk @maleadt @DilumAluthge