Conversation
Keno
reviewed
Jan 11, 2023
|
|
||
| // Technically not ismutationfree, but there's a separate system to deal | ||
| // with mutations for global state. | ||
| jl_module_type->ismutationfree = 1; |
Member
Author
There was a problem hiding this comment.
Ah, right.. I found it a bit weird to mark Module as ismutationfree, but I think we have to do so.
- set up the `isidentityfree` query as `ismutationfree` and refactor `is_consistent_type` a bit using it - move the special handling of `Module`-type's `mutationfree` bit to `Core.Compiler` since it is entangled with the implementation detail within `Core.Compiler`
fa1506d to
99caed9
Compare
Keno
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isidentityfreequery asismutationfreeand refactoris_consistent_typea bit using itModule-type'smutationfreebit toCore.Compilersince it is entangled with the implementation detail withinCore.Compiler