Some small patch for typeintersect.#48224
Merged
N5N3 merged 3 commits intoJuliaLang:masterfrom Jan 12, 2023
Merged
Conversation
They might be recreated in `finish_unionall`, (thus `lookup` returns false.) But their bounds might still live in the current env. close JuliaLang#44395. (JuliaLang#44395 could also be fixed by the fast path added in JuliaLang#48221. This commit would skip more `intersect_var` under circular constraint.)
02f37d8 to
484ce82
Compare
vtjnash
approved these changes
Jan 11, 2023
close JuliaLang#26487. This should be valid as we never set `X<:Y<:X` (assuming `Y` is the outer var).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add var substitution forgotten in 3037342 and make the
reachable_vartest not ignore free var.