add RemoteLogger for distributed logging#48121
Closed
simonbyrne wants to merge 4 commits intomasterfrom
Closed
Conversation
Member
Author
|
@c42f any thoughts? |
cafdce9 to
e2990f8
Compare
Member
Author
|
okay, added a test |
e2990f8 to
68a1681
Compare
Member
|
cc @tanmaykm |
Member
Author
|
bump? |
Merged
Member
|
I didn't review, but now needs to be reopened at https://github.com/JuliaLang/Distributed.jl for JuliaLang/Distributed.jl#52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/Distributed.jl#51
This is a pretty crude implementation: it simply
remotecalls the logger on the main process, attaching a keywordpidto indicate which process triggered it, but I hope it can serve as a starting point.The main downside of this approach is that it doesn't respect changes to the current logger on the main task, e.g.
will still log to the global logger on the main process, not
mylogger. This also means I can't test this using@test_logs. I don't see an easy way to fix this without something like #35757.The other open question is when/where should the logger be instantiated?