Merged
Conversation
This technically has different behavior than the current behavior but I'm pretty sure that no one was using `BigFloat` with precision<53 because the current behavior is to give you all 53 bits for precision>=40 and only the leading 8 bits for precision<40. This is roughly 2x faster for precision<10000. It's a little slower for precisions >10^6 (about 20%) but IMO this doesn't really matter since for high precision things like multiplication will be way slower than construction.
Member
Author
|
The tests this is failing are tests of |
Member
Author
|
This is ready to merge and is a noticeable performance improvement if we don't mind the added complexity. |
KristofferC
reviewed
Nov 29, 2022
Member
|
Yeah, why not. When has adding a little implementation complexity for the sake of speed stopped us? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This technically has different behavior than the current behavior but I'm pretty sure that no one was using
BigFloatwith precision<53 because the current behavior is to give you all 53 bits for precision>=40 and only the leading 8 bits for precision<40. This is roughly 2x faster for precision<10000. It's a little slower for precisions >10^6 (about 20%) but IMO this doesn't really matter since for high precision things like multiplication will be way slower than construction.