Skip to content

irshow: Fix CFG display with directly inserted new nodes#47135

Merged
aviatesk merged 1 commit intomasterfrom
kf/47043_followup
Oct 13, 2022
Merged

irshow: Fix CFG display with directly inserted new nodes#47135
aviatesk merged 1 commit intomasterfrom
kf/47043_followup

Conversation

@Keno
Copy link
Copy Markdown
Member

@Keno Keno commented Oct 12, 2022

Slight fix to #47043 for the case where nodes where inserted using insert_node_here!.

@Keno Keno requested a review from maleadt October 12, 2022 04:24
Copy link
Copy Markdown
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

CI failures seem unrelated.

@maleadt maleadt added display and printing Aesthetics and correctness of printed representations of objects. compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) merge me PR is reviewed. Merge when all tests are passing labels Oct 12, 2022
Slight fix to #47043 for the case where nodes where inserted using
`insert_node_here!`.
@aviatesk aviatesk merged commit 08d5b0d into master Oct 13, 2022
@aviatesk aviatesk deleted the kf/47043_followup branch October 13, 2022 15:04
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) display and printing Aesthetics and correctness of printed representations of objects.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants