Add editor support for helix#47042
Merged
KristofferC merged 1 commit intoJuliaLang:masterfrom Oct 4, 2022
Merged
Conversation
| define_editor(Any["micro", "kak"]; wait=true) do cmd, path, line, column | ||
| `$cmd +$line $path` | ||
| end | ||
| define_editor(Any["hx", "helix"]; wait=true) do cmd, path, line, column |
Member
There was a problem hiding this comment.
I know you're copying from another line but I'm not sure why we need the Any here.
Contributor
Author
There was a problem hiding this comment.
Me neither - this array ends up being passed to editor_matches right above this function, which doesn't seem to care about the type either way.
Member
There was a problem hiding this comment.
If you look a bit below there is an array of Strings without Any. So I would say it's not needed, there is one which has Strings and Regexes which might have led to other people just assuming it was the way.
StefanKarpinski
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://helix-editor.com