Add JITLink ELF debugger support#47037
Conversation
vtjnash
left a comment
There was a problem hiding this comment.
SGTM. But I don't know anything about this
|
Apolgoies, won't have any bandwidth for this for a few days (and haven't looked at EPCDebugObjectRegistrar yet). If it a) compiles on macOS/ARM64, and b) registers a code block with LLDB in a cursory test (I forget whether there is CI test coverage), it's probably fine. |
|
Just saw that this is still sitting unmerged – I'm not sure I have much useful to add (and no commit access either way). I might have enabled I'm also not sure whether there is any advantage to synthesising the |
d168c14 to
becc171
Compare
|
Does this turn off the ability to do JIT debugging on macho? (I'm not sure this ever worked but in a more theoritical sense) |
There isn't any immediate benefit, but I figure the cost is pretty low to route it through Create, and maybe in the future upstream LLVM will do something fancy in Create that can't be applied to a new call (e.g. give back the correct plugin).
No, we still add the MachO plugin when we're emitting to MachO format. |
GDBJITDebugInfoRegistrationPlugin only supports MachO debugger support; EPCDebugObjectRegistrar is used for ELF debugger support.