Inlining/Finalizer-elimination cleanup refactor#46700
Merged
Conversation
This started as an attempt to fix the broken test at [1], but I don't actually think that test ever worked. I still intend to fix that, but this PR is prepratory, merging code paths that basically did identical things, but were incomplete in some cases. Also some general quality improvements. The test case in question is better now (everything gets inlined and it's down to needing to prove that the finalizer itself is inlineable and the mutable :new is eliminable), but not quite fixed. [1] https://github.com/JuliaLang/julia/blob/master/test/compiler/inline.jl#L1306
aviatesk
reviewed
Sep 12, 2022
| if inline::Bool && try_inline_finalizer!(ir, argexprs, maxval, mi, inlining) | ||
| # the finalizer body has been inlined | ||
| flags = info === nothing ? UInt8(0) : flags_for_effects(info.effects) | ||
| if length(finalizer_stmt.args) >= 4 |
Member
There was a problem hiding this comment.
Shouldn't this be length(finalizer_stmt.args) >= 5?
| end | ||
| end | ||
| else | ||
| insert_node!(ir, maxval, with_flags(NewInstruction(Expr(:call, argexprs...), Nothing), flags), true) |
Member
There was a problem hiding this comment.
So is my understanding right that this branch is for generating Core.finalizer call expression that may be handled by the second run of this optimization pass?
EDIT: or maybe for external consumers who may run the inlining pass and SROA pass in a different order?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as an attempt to fix the broken test at [1], but I don't actually think that test ever worked. I still intend to fix that, but this PR is prepratory, merging code paths that basically did identical things, but were incomplete in some cases. Also some general quality improvements. The test case in question is better now (everything gets inlined and it's down to needing to prove that the finalizer itself is inlineable and the mutable :new is eliminable), but not quite fixed.
[1] https://github.com/JuliaLang/julia/blob/master/test/compiler/inline.jl#L1306