Implement mapreduce_impl for IndexCartesian.#45651
Open
N5N3 wants to merge 2 commits intoJuliaLang:masterfrom
Open
Implement mapreduce_impl for IndexCartesian.#45651N5N3 wants to merge 2 commits intoJuliaLang:masterfrom
mapreduce_impl for IndexCartesian.#45651N5N3 wants to merge 2 commits intoJuliaLang:masterfrom
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On master,
mapreducecallsmapfoldlfor inputs withIndexCartesianstyle, which brings performance pain if the 1st dimension is long enough for vectorlization.This PR implements pairwise
mapreduce_implfor better performance by cutting the highest splitable dimension in half.(As we can't reorder the inputs, and
CartesianPartitionhas much higher overhead)Test added.
A simple benchmark