cache Type{wrapper} for faster lookups#44704
Merged
JeffBezanson merged 1 commit intomasterfrom Apr 13, 2022
Merged
Conversation
Member
|
@nanosoldier |
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
vtjnash
reviewed
Mar 23, 2022
baa70a4 to
fe34430
Compare
vtjnash
reviewed
Apr 6, 2022
vtjnash
reviewed
Apr 6, 2022
vtjnash
reviewed
Apr 6, 2022
vtjnash
reviewed
Apr 6, 2022
Comment on lines
+571
to
573
| jl_serialize_value(s, tn->Typeofwrapper); | ||
| jl_serialize_value_(s, (jl_value_t*)tn->cache, 0); | ||
| jl_serialize_value_(s, (jl_value_t*)tn->linearcache, 0); |
Member
There was a problem hiding this comment.
Suggested change
| jl_serialize_value(s, tn->Typeofwrapper); | |
| jl_serialize_value_(s, (jl_value_t*)tn->cache, 0); | |
| jl_serialize_value_(s, (jl_value_t*)tn->linearcache, 0); | |
| jl_serialize_value(s, jl_atomic_load_acquire(&tn->Typeofwrapper)); | |
| jl_serialize_value_(s, (jl_value_t*)jl_atomic_load_acquire(&tn->cache), 0); | |
| jl_serialize_value_(s, (jl_value_t*)jl_atomic_load_acquire(&tn->linearcache), 0); |
(I don't yet have this file enabled for this static-analysis check, since there are other similar updates missing too)
mostly fixes #44402 Co-authored-by: Jameson Nash <vtjnash@gmail.com>
fe34430 to
29a3585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark from #44402:
alternative to #44447
mostly fixes #44402