[Distributed] Return value obtained from call_on_owner directly#43398
Merged
Sacha0 merged 1 commit intoJuliaLang:masterfrom Dec 11, 2021
krynju:kr/distributed-remote-fetch-fix
Merged
[Distributed] Return value obtained from call_on_owner directly#43398Sacha0 merged 1 commit intoJuliaLang:masterfrom krynju:kr/distributed-remote-fetch-fix
call_on_owner directly#43398Sacha0 merged 1 commit intoJuliaLang:masterfrom
krynju:kr/distributed-remote-fetch-fix
Conversation
vtjnash
approved these changes
Dec 11, 2021
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43396
Caused by this: #42339
v_localstores the value obtained throughcall_on_owner.I forgot this value is not wrapped in
Someand the code was attemptingto unwrap it withsomethingat the end of the function.Worked well for non-
nothingvalues, but whenfetchwas actually returning anothingvalue then an error was thrown due tosomething(nothing)being illegal2nd test case is not related to the issue, but added it for safety in case there's any further work done on this part of code