Skip to content

Backport LLVM 12.0.1-4 bump to 1.7#42535

Merged
vchuravy merged 4 commits intobackports-release-1.7from
vc/bp_llvm12.0.1-4
Oct 14, 2021
Merged

Backport LLVM 12.0.1-4 bump to 1.7#42535
vchuravy merged 4 commits intobackports-release-1.7from
vc/bp_llvm12.0.1-4

Conversation

@vchuravy
Copy link
Copy Markdown
Member

@vchuravy vchuravy commented Oct 7, 2021

Includes:

@vchuravy vchuravy added the upstream The issue is with an upstream dependency, e.g. LLVM label Oct 7, 2021
@DilumAluthge DilumAluthge reopened this Oct 8, 2021
@DilumAluthge
Copy link
Copy Markdown
Member

DilumAluthge commented Oct 8, 2021 •
edited
Loading

@vchuravy Can you rebase this PR (and force-push) and see if that triggers Buildkite?

@DilumAluthge
Copy link
Copy Markdown
Member

DilumAluthge commented Oct 8, 2021

Thanks! Okay, it looks like Buildkite is now running on this PR.

@DilumAluthge
Copy link
Copy Markdown
Member

DilumAluthge commented Oct 8, 2021

Note: the Buildkite failures in the file and read test sets will be fixed once #42533 is backported to 1.7.

@vchuravy
Copy link
Copy Markdown
Member Author

vchuravy commented Oct 8, 2021

FreeBSD tells me that my backport was not sufficient:

ERROR: Unable to load dependent library /usr/home/julia/buildbot/w2_tester/tester_freebsd64/build/bin/../lib/julia/libjulia-internal.so.1
Message:Shared object "libz.so.1" not found, required by "libLLVM-12jl.so"

but this might also be RPATH? @vtjnash

@Sacha0
Copy link
Copy Markdown
Member

Sacha0 commented Oct 8, 2021

Might I ask that we hold off with merging this backport till we are certain it will not introduce new build breakage for consumers of RC2? :)

@vchuravy vchuravy added this to the 1.7 milestone Oct 8, 2021
@vchuravy vchuravy force-pushed the vc/bp_llvm12.0.1-4 branch 2 times, most recently from d01b0f7 to b1f569a Compare October 9, 2021 14:02
@vchuravy
Copy link
Copy Markdown
Member Author

vchuravy commented Oct 10, 2021

@Sacha0 can you test whether this branch also breaks your NixOs setup?

@Sacha0
Copy link
Copy Markdown
Member

Sacha0 commented Oct 10, 2021

Sure thing, I'll pull this patch onto our 1.7 testing branch and report back. Thanks again! :)

@Sacha0
Copy link
Copy Markdown
Member

Sacha0 commented Oct 12, 2021

To confirm, this branch breaks our 1.7 test builds with the same failure mode that the bump on master broke our master test builds:

../../../bin/llvm-tblgen: error while loading shared libraries: libz.so.1: cannot open shared object file: No such file or directory
make[4]: *** [include/llvm/IR/CMakeFiles/intrinsics_gen.dir/build.make:155: include/llvm/IR/Attributes.inc] Error 127
make[3]: *** [CMakeFiles/Makefile2:8973: include/llvm/IR/CMakeFiles/intrinsics_gen.dir/all] Error 2
make[3]: *** Waiting for unfinished jobs....

@vchuravy
Copy link
Copy Markdown
Member Author

vchuravy commented Oct 12, 2021

@staticfloat any ideas how we can fix the RPATH issue?

@Sacha0 currently we have no CI against NixOS so this not a supported build-configuration. Could you look into adding one?

@Sacha0
Copy link
Copy Markdown
Member

Sacha0 commented Oct 12, 2021

Regrets, I know little about NixOS and dearly want to avoid learning any more 😄.

@Sacha0
Copy link
Copy Markdown
Member

Sacha0 commented Oct 12, 2021

Paging @rbvermaa, our Nix guru, for his thoughts :). (Also ref. JuliaPackaging/Yggdrasil#3703, #42512, #42523, #42524, and #42534 for context.)

vchuravy and others added 4 commits October 13, 2021 15:02
@vchuravy
[LLVM] bump to 12.0.1-4 (#42512)
c5ff713 
* [LLVM] bump to 12.0.1-4

* Clang is now installed into usr/tools

(cherry picked from commit 538541a)
@JeffBezanson @vchuravy
fix LLVM link to include new zlib dependency (#42524)
3a383ea 
(cherry picked from commit 2f00fe1)
@vchuravy
[LLVM] actually update the branch for manual builds
6853711 
(cherry picked from commit b239886)
@rbvermaa @vchuravy
Pass location of built zlib to LLVM cmake.
0a3718e 
(cherry picked from commit 56bae3c)

and

(cherry picked from commit 88c338e)
@vchuravy
Copy link
Copy Markdown
Member Author

vchuravy commented Oct 13, 2021

@Sacha0 can you test this against your infrastructure?

@Sacha0
Copy link
Copy Markdown
Member

Sacha0 commented Oct 13, 2021

Firing off a test of this branch and master with Rob's patch in now, will report back :).

@Sacha0
Copy link
Copy Markdown
Member

Sacha0 commented Oct 13, 2021

Preliminarily it looks like both our latest-tester and 1.7-tester succeed with the addition of Rob's patch 🎉

@vchuravy vchuravy merged commit 425e573 into backports-release-1.7 Oct 14, 2021
@vchuravy vchuravy deleted the vc/bp_llvm12.0.1-4 branch October 14, 2021 01:49
@ararslan ararslan mentioned this pull request Oct 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

@KristofferC KristofferC Awaiting requested review from KristofferC

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees

No one assigned

Labels

upstream The issue is with an upstream dependency, e.g. LLVM

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

5 participants

@vchuravy @DilumAluthge @Sacha0 @JeffBezanson @rbvermaa