Skip to content

make read() respect lock=false#42394

Merged
vchuravy merged 1 commit intoJuliaLang:masterfrom
Moelf:read_lock_false
Sep 28, 2021
Merged

make read() respect lock=false#42394
vchuravy merged 1 commit intoJuliaLang:masterfrom
Moelf:read_lock_false

Conversation

@Moelf
Copy link
Copy Markdown
Contributor

@Moelf Moelf commented Sep 26, 2021

Close #42393

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Sep 27, 2021
@Moelf
Copy link
Copy Markdown
Contributor Author

Moelf commented Sep 27, 2021

can we backport this to 1.7? since it has some pretty hefty performance implication

@vchuravy vchuravy added io Involving the I/O subsystem: libuv, read, write, etc. backport 1.7 labels Sep 28, 2021
@vchuravy vchuravy merged commit 167984d into JuliaLang:master Sep 28, 2021
@Moelf Moelf deleted the read_lock_false branch September 28, 2021 21:42
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Sep 29, 2021
@KristofferC KristofferC mentioned this pull request Sep 29, 2021
Merged
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash approved these changes

@StefanKarpinski StefanKarpinski Awaiting requested review from StefanKarpinski

Assignees

No one assigned

Labels

io Involving the I/O subsystem: libuv, read, write, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

read(s::IOStream, T::Union{Type{Int16},Type{UInt16}...}) doesn't respect ;lock = false

5 participants

@Moelf @vtjnash @vchuravy @KristofferC @IanButterworth