Base.runtests: correctly forward the --sysimage-native-code=no flag if it is provided#42173
Closed
DilumAluthge wants to merge 1 commit intomasterfrom
Closed
Base.runtests: correctly forward the --sysimage-native-code=no flag if it is provided#42173DilumAluthge wants to merge 1 commit intomasterfrom
Base.runtests: correctly forward the --sysimage-native-code=no flag if it is provided#42173DilumAluthge wants to merge 1 commit intomasterfrom
Conversation
…ag if it is provided
ae8de72 to
98d60f9
Compare
staticfloat
reviewed
Sep 9, 2021
| run(setenv(`$(julia_cmd()) $(joinpath(Sys.BINDIR::String, | ||
| cmd = Base.julia_cmd() | ||
| if Base.JLOptions().use_sysimage_native_code == 0 | ||
| push!(cmd.exec, "--sysimage-native-code=no") |
Member
There was a problem hiding this comment.
IMO this should be a part of Base.julia_cmd().
Member
There was a problem hiding this comment.
I mean that we should do this check inside of Base.julia_cmd() and push the arguments onto that cmd object, instead of only doing it here.
Member
Author
|
Closing in favor of #42185 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #41238 (comment)