optimizer: Refactor out redundant nargs parameter#41699
Merged
Conversation
These functions have taken `nargs` parameters for a long time
and through many refactors. However, at this point, having this
parameter makes little sense. In fact, we were passing it in three
different places here:
1. As an explicit argument
2. As a field of the OptimizationState
3. Implicitly via the Method def of the MethodInstance in the
OptimizationState.
Worse, we were inconsistent about whether the first argument counted
as an argument, so there was +/- 1 between these values. Clean that
all up by deleting cases 1 and 2 and retriving it directly from the
MethodInstance in the two places that need it.
Co-authored-by: Jonas Schulze <jonas.schulze@st.ovgu.de>
vtjnash
approved these changes
Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions have taken
nargsparameters for a long timeand through many refactors. However, at this point, having this
parameter makes little sense. In fact, we were passing it in three
different places here:
OptimizationState.
Worse, we were inconsistent about whether the first argument counted
as an argument, so there was +/- 1 between these values. Clean that
all up by standardizing on the inclusive definition of nargs,
deleting cases 1 and 2 where the OptimizationState is passed and
retrieving nargs directly from the MethodInstance in the two places that need it.