also update the path of a pacakge when loading its deps from a precompile file#37608
also update the path of a pacakge when loading its deps from a precompile file#37608KristofferC merged 1 commit intomasterfrom
Conversation
|
This allows both CodeTracking and Revise to pass their tests, thanks! But yes, it could use a test. |
|
Writing a test for this is a pretty big thing (need to construct a package and have it precompile and load a dependency) etc so I'll merge this now since it improves the situation and open an issue for a test. |
|
Correction: Revise is still failing tests even with this merged, see e.g., https://ci.appveyor.com/project/timholy/revise-jl/builds/35276008/job/r1g63mu0t0l3b58x (windows) and https://travis-ci.org/github/timholy/Revise.jl/jobs/728286437 (linux). Feel free to make fake PRs on Revise if you need it to debug this. Also, |
|
I think the stdlibs need to be updated at runtime because right now the build bot path gets cached. But that looks like something else, will check it out. |
|
I think #37625 should fix it. |
Fixes #37586 (comment).
Can you try this @timholy?
Should probably write a test...