RFC: handle colors in Dict limit printing#37568
Merged
KristofferC merged 3 commits intomasterfrom May 11, 2022
Merged
Conversation
d53fdc3 to
39480bd
Compare
59fe95c to
5ae0a43
Compare
vtjnash
reviewed
May 9, 2022
base/show.jl
Outdated
| return (i_prev => c), (i, m_st) | ||
| end | ||
|
|
||
| function _truncate_at_width_or_chars(io::IO, str, width, chars="", truncmark="…") |
Member
There was a problem hiding this comment.
I am not sure it is worthwhile to compile this function for every io type it might encounter (which is usually on the order of 5 with various IOContext/TTY/IOBuffer combinations)
Suggested change
| function _truncate_at_width_or_chars(io::IO, str, width, chars="", truncmark="…") | |
| function _truncate_at_width_or_chars(ignore_ansi::Bool, str, width, chars="", truncmark="…") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dictionary prints values compactly, it cuts off the values after a certain number of characters and writes a couple of dots. In presence of colors, this doesn't work properly, because the computation of the width of the line will be wrong, and the printer might cut off the printing in the middle of the color sequence, corrupting the terminal color state. As an example, the following code
now shows in the REPL as
with this PR, it shows as:
The original reason for making this PR is that I made some struct print with color but then it printed as:
With this PR, it prints as:

Marking as RFC because I don't know if we want to deal with colors inside containers in the display system outside of
MIME("text/plain").Haven't added tests yet because they are annoying to write and want to see that people are ok with this first.
Fixes #44718