Disable all git EOL conversions#32781
Merged
vtjnash merged 1 commit intoJuliaLang:masterfrom Oct 15, 2019
Merged
Conversation
Member
|
doesn't turning off the text attribute also prevent nice diffs? |
Contributor
Author
|
My understanding is that the But probably worth trying things out on a number of systems, just to be sure we’re not breaking things. |
vtjnash
approved these changes
Aug 4, 2019
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #27291, or rather is a second attempt to achieve the same thing. #27291 was reverted because it only worked with git >=2.10 and that was deemed unacceptable.
I think this PR here should also work with older git versions, but I'm not 100% positive.
I think if this was merged it should happen sometime early in a release cycle. If this PR does not work for some reason, it would probably be fairly disruptive, so better to try it early in a cycle rather than just before a release. So now might be a good time :)
CCing @vtjnash, @ararslan.