Skip to content

import partr code, allow using it in threaded loops#31398

Merged
JeffBezanson merged 2 commits intomasterfrom
jn/kp/partr2
Mar 22, 2019
Merged

import partr code, allow using it in threaded loops#31398
JeffBezanson merged 2 commits intomasterfrom
jn/kp/partr2

Conversation

@JeffBezanson
Copy link
Copy Markdown
Member

Rebased version of #30731.

@JeffBezanson JeffBezanson added the multithreading Base.Threads and related functionality label Mar 19, 2019
@vchuravy
Copy link
Copy Markdown
Member

So if I read this right tasks are only processed on the workers if we are in a threaded loop, but only the ones that are started by @threads and not the ones that are queued up outside?

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Mar 19, 2019

It'll make progress on all tasks while inside an @threads block. Outside that block, the logic to automatically (dis)engage the @threads logic is currently not implemented.

drop/fix more broken code
drop jl_thread_sleep_threshold deadcode
improve jl_wakeup_thread
@AzamatB
Copy link
Copy Markdown
Contributor

AzamatB commented Mar 27, 2019

Does this mean that the functionality of #22631 is now added to the Julia?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multithreading Base.Threads and related functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants