fix maximum on generic orders#30441
Merged
ViralBShah merged 2 commits intoJuliaLang:masterfrom Dec 20, 2018
Merged
Conversation
Member
|
@nanosoldier |
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
jw3126
commented
Dec 19, 2018
Contributor
Author
|
This is still as fast: julia> using BenchmarkTools; arr = randn(10^6); @benchmark maximum($arr)
[ Info: Precompiling BenchmarkTools [6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf]
BenchmarkTools.Trial:
memory estimate: 0 bytes
allocs estimate: 0
--------------
minimum time: 560.122 μs (0.00% GC)
median time: 587.918 μs (0.00% GC)
mean time: 593.810 μs (0.00% GC)
maximum time: 1.197 ms (0.00% GC)
--------------
samples: 8328
evals/sample: 1 |
Member
|
Good to merge? |
mbauman
approved these changes
Dec 19, 2018
Contributor
Author
|
I also think so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30436
See #30320