Skip to content

Allow non-Function args to retry#30382

Merged
simonbyrne merged 7 commits intomasterfrom
sb/retry
Feb 12, 2019
Merged

Allow non-Function args to retry#30382
simonbyrne merged 7 commits intomasterfrom
sb/retry

Conversation

@simonbyrne
Copy link
Copy Markdown
Member

I hit this while trying to use a PyObject

I hit this while trying to use a `PyObject`
@ararslan ararslan added needs tests Unit tests are required for this change needs news A NEWS entry is required for this change labels Dec 13, 2018
@simonbyrne
Copy link
Copy Markdown
Member Author

simonbyrne commented Dec 13, 2018

@ararslan it should already be tested. Or is there a standard way for testing "works with a callable non-Function"?

@ararslan
Copy link
Copy Markdown
Member

I dunno, just try passing something that isn't a function (like e.g. a type) and see what happen?

@ararslan ararslan removed the needs news A NEWS entry is required for this change label Dec 13, 2018
@ararslan ararslan removed the needs tests Unit tests are required for this change label Dec 14, 2018
@fredrikekre
Copy link
Copy Markdown
Member

Add

!!! compat "Julia 1.2"
    Before Julia 1.2 this signature was restricted to `f::Function`.

before the examples in the docstring?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants