fewer convert methods for Missing and Nothing#30205
Closed
JeffBezanson wants to merge 2 commits intomasterfrom
Closed
fewer convert methods for Missing and Nothing#30205JeffBezanson wants to merge 2 commits intomasterfrom
convert methods for Missing and Nothing#30205JeffBezanson wants to merge 2 commits intomasterfrom
Conversation
nalimilan
approved these changes
Nov 30, 2018
Member
Author
|
Somehow changing those methods causes sparse array broadcast to allocate... |
Member
|
I think we've been changing all of these to use That would also perhaps remove the Union from the signature and instead the expression of these rules would be something like (with a check that convert(T::Type{Any}, x) = x
convert(T::Type{Union{}}, x) = throw(MethodError(convert, (Union{}, x)))
convert(T::Type{>:Union{Missing, Nothing}}, x) = convert(typesubtract(typesubtract(T, Nothing), Missing), x)
convert(T::Type{>:Missing}, x) = convert(typesubtract(T, Missing), x)
convert(T::Type{>:Nothing}, x) = convert(typesubtract(T, Nothing), x) |
Member
Author
|
Replaced by #31602 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@isdefinedis a better approach than trying to add lots of methods to cover all cases. Some of the methods created bad cases for specificity. In particular defining conversions fromAny(convert(::T, ::Any)) should be minimized since they tend to conflict with the fallbackconvert(::Type{T}, ::T).