Skip to content

A couple more testsets for operators#29728

Merged
kshyatt merged 1 commit intomasterfrom
ksh/testsetops
Oct 22, 2018
Merged

A couple more testsets for operators#29728
kshyatt merged 1 commit intomasterfrom
ksh/testsetops

Conversation

@kshyatt
Copy link
Copy Markdown
Member

@kshyatt kshyatt commented Oct 19, 2018

No description provided.

@kshyatt kshyatt added the test This change adds or pertains to unit tests label Oct 19, 2018

@test ifelse(true, 1, 2) == 1
@test ifelse(false, 1, 2) == 2
@testset "ifself" begin
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@testset "ifself" begin
@testset "ifelse" begin

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops!

@kshyatt kshyatt merged commit c162219 into master Oct 22, 2018
@kshyatt kshyatt deleted the ksh/testsetops branch October 22, 2018 17:35
@fredrikekre
Copy link
Copy Markdown
Member

I am sure it passes, but maybe should have run CI?

@kshyatt
Copy link
Copy Markdown
Member Author

kshyatt commented Oct 22, 2018

Oh yuck, it did run the first time and I thought it had again. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test This change adds or pertains to unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants