Add proper ASAN support to task switching#29489
Merged
Conversation
6cabf10 to
6a9b94f
Compare
Member
Author
|
@vtjnash would you mind if I rewrite I should also note that this is not yet complete, since ASAN is still not happy so I most likely missed a switch. |
Member
|
Sure, however you feel is convenient. I settled on this API to emphasize that it is expected to only access this field. But it’s not a hard restriction. |
vtjnash
reviewed
Oct 4, 2018
Merged
1624377 to
8689c79
Compare
vchuravy
commented
Jul 29, 2019
Member
|
Seems good |
e71f435 to
45f0102
Compare
2e831f2 to
4e897bb
Compare
4e897bb to
76cd218
Compare
Member
|
Haha oops. Wellllll, it was fun anyway! 😂 And an interesting exercise! |
Member
|
Causes this compiler warning: |
Member
Author
|
Sorry about that, noticed it after merging. I have included a fix in #33259 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we are using ASAN we need to inform it when we switch stacks.
Originally needed by #22631
@vtjnash any ideas for how to do this cleverly?