Skip to content

another finalizer order fix#28107

Merged
JeffBezanson merged 2 commits intomasterfrom
jb/morefinalizerorder
Jul 15, 2018
Merged

another finalizer order fix#28107
JeffBezanson merged 2 commits intomasterfrom
jb/morefinalizerorder

Conversation

@JeffBezanson
Copy link
Copy Markdown
Member

@JeffBezanson JeffBezanson commented Jul 13, 2018

This makes the atexit hook in Logging unnecessary.

Before:

julia> finalizer(println, [])
0-element Array{Any,1}

julia> 
error in running finalizer: ArgumentError(msg="stream is closed or unusable")
jeff@gurren:~/src/julia$ ./julia -q
julia> finalizer(x->@info(x), [])
0-element Array{Any,1}

julia> 
[ Info: Any[]

after:

julia> finalizer(println, [])
0-element Array{Any,1}

julia> 
Any[]
jeff@gurren:~/src/julia$ ./julia -q
julia> finalizer(x->@info(x), [])
0-element Array{Any,1}

julia> 
[ Info: Any[]

@JeffBezanson
improve order of run_all_finalizers
8e3fe01 
This ordering makes it much more likely that older finalizers will
run first.
@JeffBezanson
remove atexit Logging handler
5932b85 
This is fixed more generally by running finalizers in stack order.
@JeffBezanson JeffBezanson merged commit 67ca557 into master Jul 15, 2018
@JeffBezanson JeffBezanson deleted the jb/morefinalizerorder branch July 15, 2018 03:23
@vtjnash vtjnash mentioned this pull request Aug 3, 2018
Closed
@c42f c42f mentioned this pull request Sep 19, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JeffBezanson